Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CPU] Added support for network inputs and outputs with the same name. #5000

Merged
merged 11 commits into from
May 28, 2021

Conversation

maxnick
Copy link
Contributor

@maxnick maxnick commented Mar 29, 2021

Details:

The purpose of this PR is to support, at the CPU plug-in level, the case where both the input and the output of the network have the same name. This case is valid, for example, in Parameter->Result network. Now in case if the network inputs and outputs have the same name they will share the same data blob.

Tickets:

  • 51087

@maxnick maxnick changed the title [CPU] Added support for the same names of network inputs and outputs. [CPU] Added support for network inputs and outputs with the same name. Mar 30, 2021
@maxnick maxnick marked this pull request as ready for review March 30, 2021 16:28
@maxnick maxnick requested review from a team March 30, 2021 16:28
@maxnick maxnick added the category: CPU OpenVINO CPU plugin label Mar 30, 2021
@maxnick maxnick requested review from vladislav-volkov and mandrono and removed request for a team March 30, 2021 16:28
@maxnick
Copy link
Contributor Author

maxnick commented Mar 30, 2021

@vladislav-volkov, @mandrono could you please review?

@maxnick
Copy link
Contributor Author

maxnick commented Apr 13, 2021

@mandrono Thank you!!!
@dmitry-gorokhov Could you please review?

@maxnick maxnick requested a review from dmitry-gorokhov April 13, 2021 16:11
@maxnick maxnick force-pushed the ParameterResultNetwork branch 3 times, most recently from 65cb493 to 46896d0 Compare April 26, 2021 08:44
@dmitry-gorokhov dmitry-gorokhov added this to the 2021.4 milestone Apr 30, 2021
@dmitry-gorokhov dmitry-gorokhov self-assigned this Apr 30, 2021
@maxnick maxnick force-pushed the ParameterResultNetwork branch from 46896d0 to 5f39c3a Compare May 7, 2021 09:38
@maxnick maxnick force-pushed the ParameterResultNetwork branch from 5f39c3a to f6c7687 Compare May 12, 2021 09:10
@maxnick
Copy link
Contributor Author

maxnick commented May 12, 2021

@dmitry-gorokhov, all comments have been applied.

@maxnick maxnick requested a review from dmitry-gorokhov May 12, 2021 14:43
Copy link
Contributor

@dmitry-gorokhov dmitry-gorokhov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will merge after internal validation

@maxnick maxnick force-pushed the ParameterResultNetwork branch 2 times, most recently from 94a1181 to 2942a54 Compare May 25, 2021 15:58
@maxnick maxnick force-pushed the ParameterResultNetwork branch from 2942a54 to 7ced6a2 Compare May 27, 2021 06:56
@dmitry-gorokhov dmitry-gorokhov merged commit ad0e0c9 into openvinotoolkit:master May 28, 2021
@maxnick maxnick deleted the ParameterResultNetwork branch October 27, 2021 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: CPU OpenVINO CPU plugin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Segmentation Fault in libMKLDNNPlugin.so when using blobs with pre-allocated buffers
3 participants